Thread (47 messages) 47 messages, 9 authors, 2019-10-02

Re: [PATCH bpf-next 2/6] libbpf: move bpf_helpers.h, bpf_endian.h into libbpf

From: Andrii Nakryiko <hidden>
Date: 2019-09-30 23:30:15
Also in: bpf

On Mon, Sep 30, 2019 at 4:18 PM Jakub Kicinski
[off-list ref] wrote:
On Mon, 30 Sep 2019 15:58:35 -0700, Andrii Nakryiko wrote:
quoted
On Mon, Sep 30, 2019 at 3:55 PM Song Liu [off-list ref] wrote:
quoted
On Mon, Sep 30, 2019 at 1:43 PM Andrii Nakryiko [off-list ref] wrote:
quoted
Make bpf_helpers.h and bpf_endian.h official part of libbpf. Ensure they
are installed along the other libbpf headers.

Signed-off-by: Andrii Nakryiko <redacted>
Can we merge/rearrange 2/6 and 3/6, so they is a git-rename instead of
many +++ and ---?
I arranged them that way because of Github sync. We don't sync
selftests/bpf changes to Github, and it causes more churn if commits
have a mix of libbpf and selftests changes.

I didn't modify bpf_helpers.h/bpf_endian.h between those patches, so
don't worry about reviewing contents ;)
I thought we were over this :/ Please merge the patches.
I'll merge those two patches, our sync script can handle that now,
though with a bit of human input. I'm not exactly sure on the "why"
though, I think generally splitting libbpf changes and selftests
changes is a good thing, no?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help