Re: [PATCH net 0/4] net: bcmgenet: restore internal EPHY support
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2019-10-17 04:00:10
Also in:
lkml
On 10/16/2019 4:06 PM, Doug Berger wrote:
I managed to get my hands on an old BCM97435SVMB board to do some testing with the latest kernel and uncovered a number of things that managed to get broken over the years (some by me ;). This commit set attempts to correct the errors I observed in my testing. The first commit applies to all internal PHYs to restore proper reporting of link status when a link comes up. The second commit restores the soft reset to the initialization of the older internal EPHYs used by 40nm Set-Top Box devices. The third corrects a bug I introduced when removing excessive soft resets by altering the initialization sequence in a way that keeps the GENETv3 MAC interface happy. Finally, I observed a number of issues when manually configuring the network interface of the older EPHYs that appear to be resolved by the fourth commit.
Thank you very much for addressing all of those problems!
Doug Berger (4): net: bcmgenet: don't set phydev->link from MAC net: phy: bcm7xxx: define soft_reset for 40nm EPHY net: bcmgenet: soft reset 40nm EPHYs before MAC init net: bcmgenet: reset 40nm EPHY on energy detect drivers/net/ethernet/broadcom/genet/bcmgenet.c | 41 +++++---- drivers/net/ethernet/broadcom/genet/bcmgenet.h | 2 +- drivers/net/ethernet/broadcom/genet/bcmmii.c | 112 +++++++++++-------------- drivers/net/phy/bcm7xxx.c | 1 + 4 files changed, 79 insertions(+), 77 deletions(-)
-- Florian