Re: [PATCH net-next v7 14/17] ethtool: set link settings with LINKINFO_SET request
From: Jiri Pirko <jiri@resnulli.us>
Date: 2019-10-12 16:33:14
Also in:
lkml
From: Jiri Pirko <jiri@resnulli.us>
Date: 2019-10-12 16:33:14
Also in:
lkml
Wed, Oct 09, 2019 at 10:59:43PM CEST, mkubecek@suse.cz wrote: [...]
+static const struct nla_policy linkinfo_hdr_policy[ETHTOOL_A_HEADER_MAX + 1] = {
+ [ETHTOOL_A_HEADER_UNSPEC] = { .type = NLA_REJECT },
+ [ETHTOOL_A_HEADER_DEV_INDEX] = { .type = NLA_U32 },
+ [ETHTOOL_A_HEADER_DEV_NAME] = { .type = NLA_NUL_STRING,
+ .len = IFNAMSIZ - 1 },Please make ETHTOOL_A_HEADER_DEV_NAME accept alternative names as well. Just s/IFNAMSIZ/ALTIFNAMSIZ should be enough.
+ [ETHTOOL_A_HEADER_GFLAGS] = { .type = NLA_U32 },
+ [ETHTOOL_A_HEADER_RFLAGS] = { .type = NLA_REJECT },
+};[...]