Re: [PATCH 04/11] net: phylink: switch to using fwnode_gpiod_get_index()
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2019-09-11 09:46:25
Also in:
linux-gpio, lkml
On Wed, Sep 11, 2019 at 10:39:14AM +0100, Russell King - ARM Linux admin wrote:
On Wed, Sep 11, 2019 at 12:25:14PM +0300, Andy Shevchenko wrote:quoted
On Wed, Sep 11, 2019 at 12:52:08AM -0700, Dmitry Torokhov wrote:quoted
Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit works with arbitrary firmware node.I'm wondering if it's possible to step forward and replace fwnode_get_gpiod_index by gpiod_get() / gpiod_get_index() here and in other cases in this series.No, those require a struct device, but we have none. There are network drivers where there is a struct device for the network complex, but only DT nodes for the individual network interfaces. So no, gpiod_* really doesn't work.
In the following patch the node is derived from struct device. So, I believe some cases can be handled differently. -- With Best Regards, Andy Shevchenko