Thread (13 messages) 13 messages, 5 authors, 2019-09-23

Re: [PATCH] Bluetooth: hidp: Fix error checks in hidp_get/set_raw_report

From: Dan Carpenter <hidden>
Date: 2019-09-06 14:09:03
Also in: linux-bluetooth, lkml

On Fri, Sep 06, 2019 at 03:56:29PM +0200, Marcel Holtmann wrote:
Hi Dan,
quoted
Commit 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return
number of queued bytes") changed hidp_send_message to return non-zero
values on success, which some other bits did not expect. This caused
spurious errors to be propagated through the stack, breaking some (all?)
drivers, such as hid-sony for the Dualshock 4 in Bluetooth mode.

Signed-off-by: Dan Elkouby <redacted>
---
net/bluetooth/hidp/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
The v2 added an additional fix and used the Fixes tag.  Could you apply
that instead?

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help