Thread (13 messages) 13 messages, 5 authors, 2019-09-23

Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2019-09-06 13:57:26
Also in: linux-bluetooth, linux-input, lkml

Hi Jiri,
quoted
hidp_send_message was changed to return non-zero values on success,
which some other bits did not expect. This caused spurious errors to be
propagated through the stack, breaking some drivers, such as hid-sony
for the Dualshock 4 in Bluetooth mode.

As pointed out by Dan Carpenter, hid-microsoft directly relied on that
assumption as well.

Fixes: 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return number of queued bytes")

Signed-off-by: Dan Elkouby <redacted>
Reviewed-by: Jiri Kosina <redacted>

Marcel, are you taking this through your tree?
I am taking this through my tree. And yes, I applied the updated patch, but answered the other ;)

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help