Re: [PATCH net] mvpp2: fix panic on module removal

From
David Miller <davem@davemloft.net>
Date
2019-08-05 20:54:21
Also in
lkml
Reply to
Matteo Croce, 2019-08-05
From: Matteo Croce <redacted>
Date: Mon, 5 Aug 2019 20:17:39 +0200
On Mon, Aug 5, 2019 at 7:58 PM David Miller [off-list ref] wrote:
quoted
From: Matteo Croce <redacted>
Date: Wed, 31 Jul 2019 20:31:16 +0200
quoted
mvpp2 uses a delayed workqueue to gather traffic statistics.
On module removal the workqueue can be destroyed before calling
cancel_delayed_work_sync() on its works.
Fix it by moving the destroy_workqueue() call after mvpp2_port_remove().
Please post a new version with the flush_workqueue() removed.
Hi,

I thought that it was already merged:

https://lore.kernel.org/netdev/20190801121330.30823-1-mcroce@redhat.com/ (local)

Let me know if it's ok already.
Oops, my bad. :-)
Thread (7 messages) 7 messages, 3 authors, last reply 2019-08-05
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help