Re: [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver

Hello Andrew,

On Fri, Jul 19, 2019 at 6:57 PM Andrew Lunn [off-list ref] wrote:

On Fri, Jul 19, 2019 at 05:23:45PM +0530, Sagar Kadam wrote:

quoted

quoted

+&eth0 {
+       status = "okay";
+       phy-mode = "gmii";
+       phy-handle = <&phy1>;
+       phy1: ethernet-phy@0 {
+               reg = <0>;
+       };

Hi Sagar

Is there a good reason to call it phy1? Is there a phy0?

Sorry for the delayed response.
There is a single phy, so yes phy0 is a better name.
Thank you for pointing this out.

Thanks & Regards,
Sagar Kadam

Thanks

   Andrew

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv