Thread (18 messages) flat view 18 messages, 5 authors, 2019-06-27

Re: [PATCH] flow_dissector: Fix vlan header offset in __skb_flow_dissect

From: David Miller <davem@davemloft.net>
Date: 2019-06-22 23:19:58
Also in: lkml

From: YueHaibing <redacted>
Date: Thu, 20 Jun 2019 00:01:32 +0800
quoted hunk ↗ jump to hunk
@@ -785,6 +785,9 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
 		    skb && skb_vlan_tag_present(skb)) {
 			proto = skb->protocol;
 		} else {
+			if (dissector_vlan == FLOW_DISSECTOR_KEY_MAX)
+				nhoff -=  sizeof(*vlan);
Even if this would have turned out to be the desired fix, you would need
to get rid of the extra spaces in that last statement.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help