Re: [PATCH] bonding: Always enable vlan tx offload

On Wed, Jun 26, 2019 at 06:48:53PM +0200, Jiri Pirko wrote:

Wed, Jun 26, 2019 at 06:13:38PM CEST, mirq-linux@rere.qmqm.pl wrote:

quoted

On Wed, Jun 26, 2019 at 04:08:44PM +0800, YueHaibing wrote:

[...]

quoted

quoted

This patch always enable bonding's vlan tx offload, pass the vlan
packets to the slave devices with vlan tci, let them to handle
vlan implementation.

[...]

quoted

I can see that bonding driver uses dev_queue_xmit() to pass packets to
slave links, but I can't see where in the path it does software fallback
for devices without HW VLAN tagging. Generally drivers that don't ever
do VLAN offload also ignore vlan_tci presence. Am I missing something
here?

validate_xmit_skb->validate_xmit_vlan

Yes it is. Thanks!

Best Regards,
Michał Mirosław