Thread (10 messages) 10 messages, 6 authors, 2019-06-26

Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates

From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2019-06-21 14:05:08
Also in: linux-kernel-mentees, linux-pci, lkml

[+cc Stephen]

On Fri, Jun 21, 2019 at 03:16:04PM +0530, Puranjay Mohan wrote:
This patch series removes the private duplicates of PCI definitions in
favour of generic definitions defined in pci_regs.h.

This driver only uses some of the generic PCI definitons,
which are included from pci_regs.h and thier private versions
are removed from skfbi.h with all other private defines.

The skfbi.h defines PCI_REV_ID and other private defines with different
names, these are renamed to Generic PCI names to make them
compatible with defines in pci_regs.h.

All unused defines are removed from skfbi.h.

Puranjay Mohan (3):
  net: fddi: skfp: Rename local PCI defines to match generic PCI defines
  net: fddi: skfp: Include generic PCI definitions
  net: fddi: skfp: Remove unused private PCI definitions

 drivers/net/fddi/skfp/drvfbi.c  |  3 +-
 drivers/net/fddi/skfp/h/skfbi.h | 80 +--------------------------------
 2 files changed, 4 insertions(+), 79 deletions(-)
It's good form to CC people who have commented on previous versions of
your series, so I added Stephen.

FWIW,

Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help