Thread (63 messages) 63 messages, 6 authors, 2019-06-27

Re: [PATCH net-next 12/18] ionic: Add async link status check and basic stats

From: Shannon Nelson <hidden>
Date: 2019-06-26 15:54:15

On 6/25/19 4:47 PM, Jakub Kicinski wrote:
On Thu, 20 Jun 2019 13:24:18 -0700, Shannon Nelson wrote:
quoted
+	/* filter out the no-change cases */
+	if ((link_up && netif_carrier_ok(netdev)) ||
+	    (!link_up && !netif_carrier_ok(netdev)))
nit: these are both bools, you can compare them:

	if (link_up == netif_carrier_ok(netdev))
quoted
+		return;
Yep - thanks.
sln
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help