On 6/24/19 12:26 AM, Michal Kubecek wrote:

On Fri, Jun 21, 2019 at 03:30:20PM -0700, Shannon Nelson wrote:

quoted

On 6/20/19 7:32 PM, Michal Kubecek wrote:

quoted

On Thu, Jun 20, 2019 at 01:24:19PM -0700, Shannon Nelson wrote:
+
+	if (ch->combined_count > lif->ionic->ntxqs_per_lif)
+		return -EINVAL;
This has been already checked in ethtool_set_channels().

That's what I get for copying from an existing driver.  I'll check those and
clean them up.

The checks in general code were only added recently so most drivers
probably still have their own checks.

That would be the reason.  Thanks, I'll clean those up.

sln