Re: [PATCH v2] ss: add option to print socket information on one line

[PATCH v2] ss: add option to print socket information on one line · Josh Hunt <hidden> · 2019-05-01
Re: [PATCH v2] ss: add option to print socket information on one line · David Ahern <hidden> · 2019-05-02
Re: [PATCH v2] ss: add option to print socket information on one line · Markus Elfring <hidden> · 2019-05-30
Re: ss: Checking efficient analysis for network connections · Markus Elfring <hidden> · 2019-06-01
Re: ss: Checking efficient analysis for network connections · David Miller <davem@davemloft.net> · 2019-06-01
Re: ss: Checking efficient analysis for network connections · Markus Elfring <hidden> · 2019-06-02
Re: ss: Checking efficient analysis for network connections · Markus Elfring <hidden> · 2019-06-13
Re: ss: Checking efficient analysis for network connections · Markus Elfring <hidden> · 2019-07-23
Re: ss: Checking selected network ports · Markus Elfring <hidden> · 2019-09-16
Re: [RFC] ss: Checking selected network ports · Markus Elfring <hidden> · 2019-10-22

From: Markus Elfring <hidden>
Date: 2019-05-30 09:11:35
Also in: lkml

This software update caught also my development attention a moment ago.

quoted hunk ↗ jump to hunk

+++ b/misc/ss.c

@@ -3973,7 +3975,10 @@ static int packet_show_sock(struct nlmsghdr *nlh, void *arg)

 	if (show_details) {
 		if (pinfo) {
-			out("\n\tver:%d", pinfo->pdi_version);
+			if (oneline)
+				out(" ver:%d", pinfo->pdi_version);
+			else
+				out("\n\tver:%d", pinfo->pdi_version);
 			out(" cpy_thresh:%d", pinfo->pdi_copy_thresh);
 			out(" flags( ");
 			if (pinfo->pdi_flags & PDI_RUNNING)

I would find it nicer to use the ternary operator here.

+			out(oneline ? " ver:%d" : "\n\tver:%d",
+			    pinfo->pdi_version);


How do you think about to use more succinct statement variants?

Regards,
Markus

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help