Re: [PATCH] ath9k: remove set but not used variable 'acq'

Kalle Valo [off-list ref] writes:

Toke Høiland-Jørgensen [off-list ref] writes:

quoted

Kalle Valo [off-list ref] writes:

quoted

Toke Høiland-Jørgensen [off-list ref] writes:

quoted

YueHaibing [off-list ref] writes:

quoted

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/ath/ath9k/recv.c: In function 'ath_rx_count_airtime':
drivers/net/wireless/ath/ath9k/recv.c:1010:18: warning:
 variable 'acq' set but not used [-Wunused-but-set-variable]

It's not used after 89cea7493a34 ("ath9k: Switch to mac80211 TXQ scheduling
and airtime APIs"). Also remove related variables.

Ah, right, seems I forgot to clean that up. I wonder why I didn't get a
compiler warning for it.

I think the warning is not enabled by default and you need to use W=1
Makefile variable to enable it.

Hmm, right, thanks! Guess I should get into the habit of compiling with
warnings enabled before submitting patches :)

But you might get a lot of warnings and it could be difficult to find
new warnings from all the noise. In ath10k I just fixed all W=1 warnings
which I saw with gcc 8.1 and only now I was able to enable W=1 on my
build script.

Ah, that was what that patch series was about :)

Right, well, I guess I'll give it a shot at some point and if it's not
too annoying I'll try to keep an eye on the warnings output...

-Toke