Thread (7 messages) 7 messages, 3 authors, 2019-02-26

Re: [PATCH] ath9k: remove set but not used variable 'acq'

From: Toke Høiland-Jørgensen <hidden>
Date: 2019-02-25 10:49:27
Also in: kernel-janitors, linux-wireless

Kalle Valo [off-list ref] writes:
Toke Høiland-Jørgensen [off-list ref] writes:
quoted
YueHaibing [off-list ref] writes:
quoted
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/ath/ath9k/recv.c: In function 'ath_rx_count_airtime':
drivers/net/wireless/ath/ath9k/recv.c:1010:18: warning:
 variable 'acq' set but not used [-Wunused-but-set-variable]

It's not used after 89cea7493a34 ("ath9k: Switch to mac80211 TXQ scheduling
and airtime APIs"). Also remove related variables.
Ah, right, seems I forgot to clean that up. I wonder why I didn't get a
compiler warning for it.
I think the warning is not enabled by default and you need to use W=1
Makefile variable to enable it.
Hmm, right, thanks! Guess I should get into the habit of compiling with
warnings enabled before submitting patches :)

-Toke
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help