On Tue, Feb 5, 2019 at 10:21 PM Michal Kubecek [off-list ref] wrote:

On Tue, Feb 05, 2019 at 09:53:26AM +0530, Vasundhara Volam wrote:

quoted

On Tue, Feb 5, 2019 at 8:26 AM Jakub Kicinski

quoted

No?  We were talking about using the soon-too-come ethtool netlink
API with additional indication that given configuration request is
supposed to be persisted.  Adding more devlink parameters is exactly
the opposite of what you should be doing.

Okay. So, till then can we have the devlink wake_on_lan parameter or
you want this to be removed? Could you please clarify?

Once ethtool netlink API is available with persisted support, I can remove
this wake_on_lan parameter from devlink. Thanks.

Once you provide an interface for userspace and applications start using
it, it's hard to get rid of it. As an extreme example, the legacy ioctl
interface used by ifconfig has been declared obsolete since kernel 2.2.0
(January 1999, i.e. 20 years ago) and we still have to maintain it.

Okay Got it. I will revert only the wake_on_lan parameter and send the patch.
We will wait for soon-too-come ethtool netlink API.

Thank you.

Michal Kubecek