Re: [PATCH net-next v7 4/8] devlink: Add support for driverinit get value for devlink_port
From: Jiri Pirko <jiri@resnulli.us>
Date: 2019-01-23 11:17:32
Fri, Jan 18, 2019 at 08:09:41AM CET, vasundhara-v.volam@broadcom.com wrote:
quoted hunk ↗ jump to hunk
Add support for "driverinit" configuration mode value for devlink_port configuration parameters. Add devlink_port_param_driverinit_value_get() function to help the driver get the value from devlink_port. Also, move the common code to __devlink_param_driverinit_value_get() to be used by both device and port params. Cc: Jiri Pirko <redacted> Signed-off-by: Vasundhara Volam <redacted> --- include/net/devlink.h | 8 ++++++ net/core/devlink.c | 67 ++++++++++++++++++++++++++++++++++++++------------- 2 files changed, 58 insertions(+), 17 deletions(-)diff --git a/include/net/devlink.h b/include/net/devlink.h index 98b8a66..09f3f43 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h@@ -838,6 +838,14 @@ static inline bool devlink_dpipe_table_counter_enabled(struct devlink *devlink,{ } +static inline int +devlink_port_param_driverinit_value_get(struct devlink_port *devlink_port, + u32 param_id, + union devlink_param_value *init_val) +{ + return -EOPNOTSUPP; +}
You are missing function declaration in case IS_ENABLED(CONFIG_NET_DEVLINK Otherwise this looks fine.
+ static inline struct devlink_region * devlink_region_create(struct devlink *devlink, const char *region_name,
[...]