Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address
From: Konrad Rzeszutek Wilk <hidden>
Date: 2018-12-13 21:18:54
Also in:
kvm, lkml
From: Konrad Rzeszutek Wilk <hidden>
Date: 2018-12-13 21:18:54
Also in:
kvm, lkml
.giant snip..
quoted
+ npinned = get_user_pages_fast(uaddr, npages, write, pages); + if (npinned != npages) + goto err; +As I said I have doubts about the whole approach, but this implementation in particular isn't a good idea as it keeps the page around forever. So no THP, no NUMA rebalancing, userspace-controlled amount of memory locked up and not accounted for. Don't get me wrong it's a great patch in an ideal world. But then in an ideal world no barriers smap etc are necessary at all.
So .. suggestions on how this could be accepted? As in other ways where we still get vmap and the issues you mentioned are not troubling you? Thanks!