[PATCH 5/5] netfilter: fix error return value of nf_ct_l4proto_pernet_register_one()
From: Yafang Shao <hidden>
Date: 2018-12-05 12:56:30
Also in:
linux-fsdevel, lkml, netfilter-devel
Subsystem:
netfilter, networking [general], the rest · Maintainers:
Pablo Neira Ayuso, Florian Westphal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
If pn is NULL, it will return 0. That's not proper. We should return an error. Signed-off-by: Yafang Shao <redacted> --- net/netfilter/nf_conntrack_proto.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/netfilter/nf_conntrack_proto.c b/net/netfilter/nf_conntrack_proto.c
index 316fef3..3caf137 100644
--- a/net/netfilter/nf_conntrack_proto.c
+++ b/net/netfilter/nf_conntrack_proto.c@@ -252,6 +252,7 @@ int nf_ct_l4proto_pernet_register_one(struct net *net, goto out; } + ret = -EINVAL; pn = nf_ct_l4proto_net(net, l4proto); if (pn == NULL) goto out;
--
1.8.3.1