Re: [PATCH net-next 1/8] net: core: dev: Add extack argument to dev_open()

On 12/5/18 3:51 AM, Petr Machata wrote:

In order to pass extack together with NETDEV_PRE_UP notifications, it's
necessary to route the extack to __dev_open() from diverse (possibly
indirect) callers. One prominent API through which the notification is
invoked is dev_open().

Therefore extend dev_open() with and extra extack argument and update
all users. Most of the calls end up just encoding NULL, but bond and
team drivers have the extack readily available.

Signed-off-by: Petr Machata <petrm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Acked-by: Jiri Pirko <jiri-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Reviewed-by: Ido Schimmel <idosch-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/net/bonding/bond_main.c                     | 2 +-
 drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c | 2 +-
 drivers/net/ethernet/cisco/enic/enic_ethtool.c      | 2 +-
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c    | 2 +-
 drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c  | 2 +-
 drivers/net/ethernet/sfc/ethtool.c                  | 2 +-
 drivers/net/ethernet/sfc/falcon/ethtool.c           | 2 +-
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c   | 2 +-
 drivers/net/hyperv/netvsc_drv.c                     | 4 ++--
 drivers/net/net_failover.c                          | 8 ++++----
 drivers/net/team/team.c                             | 2 +-
 drivers/net/wireless/intersil/hostap/hostap_main.c  | 2 +-
 drivers/s390/net/qeth_l2_main.c                     | 2 +-
 drivers/s390/net/qeth_l3_main.c                     | 2 +-
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c             | 2 +-
 drivers/staging/unisys/visornic/visornic_main.c     | 2 +-
 include/linux/netdevice.h                           | 2 +-
 net/bluetooth/6lowpan.c                             | 2 +-
 net/core/dev.c                                      | 5 +++--
 net/core/netpoll.c                                  | 2 +-
 net/ipv4/ipmr.c                                     | 4 ++--
 net/ipv6/addrconf.c                                 | 2 +-
 net/ipv6/ip6mr.c                                    | 2 +-
 23 files changed, 30 insertions(+), 29 deletions(-)

Reviewed-by: David Ahern <redacted>