Re: [PATCH net-next 2/6] net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI

From
Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date
2018-11-19 20:33:17
Also in
linux-mips, linuxppc-dev, sparclinux
Reply to
Daniel Borkmann, 2018-11-19
On Mon, Nov 19, 2018 at 12:26:46PM +0100, Daniel Borkmann wrote:
On 11/10/2018 07:58 PM, Michał Mirosław wrote:
quoted
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Why you have empty commit messages for non-trivial changes like this in
4 out of 6 of your patches ...

How was it tested on the JITs you were changing? Did you test on both,
big and little endian machines?
I have only x86 boxes currently so didn't try to test others. I hope
upstreaming the series through net-next will allow us to find any
fallouts, if any. The changes are very simple, though: they move
code around (the "splitting" part) and eventually change a vlan_present
flag's position in a skbuff structure. Dependency on CPU endianness is
removed by using byte loads for the flag.

Best Regards,
Michał Mirosław
Thread (14 messages) 14 messages, 4 authors, last reply 2018-11-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help