Re: [PATCH net-next 0/6] Remove VLAN.CFI overload

From
Alexei Starovoitov <hidden>
Date
2018-11-17 03:54:30
Also in
linux-mips, linuxppc-dev, sparclinux
Reply to
David Miller, 2018-11-10
On Sat, Nov 10, 2018 at 1:48 PM David Miller [off-list ref] wrote:
From: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Date: Sat, 10 Nov 2018 19:58:29 +0100
quoted
Fix BPF code/JITs to allow for separate VLAN_PRESENT flag
storage and finally move the flag to separate storage in skbuff.

This is final step to make CLAN.CFI transparent to core Linux
networking stack.

An #ifdef is introduced temporarily to mark fragments masking
VLAN_TAG_PRESENT. This is removed altogether in the final patch.
Daniel and Alexei, please review.
It was on my todo list.
All reviews got delayed due to LPC.

I guess too late to comment now.
Anyhow I don't see the value in this patch set.
Seems like code churn.

Michal, could you please explain the reasoning?
Thread (14 messages) 14 messages, 4 authors, last reply 2018-11-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help