Re: [PATCH net-next v8 28/28] net: WireGuard secure network tunnel

From
Andrew Lunn <andrew@lunn.ch>
Date
2018-10-25 22:44:31
Also in
linux-crypto, lkml
Reply to
Jason A. Donenfeld, 2018-10-25
quoted
quoted
+#if defined(CONFIG_PM_SLEEP) && !defined(CONFIG_ANDROID)
I don't see any other code which uses this combination. Why is this
needed?
WireGuard clears private key material before going to sleep, so that
ephemeral keys never live longer in ram than their expiration date.
This works well for mostly everything, except Android devices where
crazy out-of-tree wireless drivers (such as qcacld) will actually wake
and sleep the phone constantly
Hi Jason

Out of tree is important here. To some degree, mainline does not care
about out of tree drivers. Putting in a bandaid for them does not help
get them fixed.

I would drop this bandaid. If the Android community decides to move
wireguard from mainline into their fork, they can put the bandaid back
in again, or get the driver fixed.

   Andrew
Thread (39 messages) 39 messages, 3 authors, last reply 2018-10-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help