Re: [PATCH net-next v8 28/28] net: WireGuard secure network tunnel

From
Andrew Lunn <andrew@lunn.ch>
Date
2018-10-25 22:37:53
Also in
linux-crypto, lkml
Reply to
Jason A. Donenfeld, 2018-10-25
quoted
quoted
+             net_dbg_ratelimited("%s: Could not decrypt invalid cookie response\n",
+                                 wg->dev->name);
It might be worth adding a netdev_dbg_ratelimited(), which takes a
netdev as its first parameter, just line netdev_dbg().
That sounds like it could be useful. Though, I'm trying hard to make
the first patch submission _not_ need to touch any of the rest of the
networking stack. I've actually got a small list of interesting
networking stack changes that might be useful for WireGuard, but I
think I'd prefer to submit these after this is all merged, and each
one separately for a separate discussion, if that's okay with you.
Hi Jason

I can understand that. But on the flip side, CAKE reached something
like version 19 before it got merged. Wireguard is looking similar.
An addition like the above, is not controversial. You could submit
such a single patch in a weeks time when net-next reopens, and
probably version 1 or 2 will get accepted.

	 Andrew
Thread (39 messages) 39 messages, 3 authors, last reply 2018-10-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help