RE: [PATCH net-next, v2] hv_netvsc: fix vf serial matching with pci slot info

-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org>
Sent: Friday, October 12, 2018 6:21 PM
To: Haiyang Zhang <redacted>
Cc: Haiyang Zhang <haiyangz@microsoft.com>; davem@davemloft.net;
netdev@vger.kernel.org; olaf@aepfle.de; linux-kernel@vger.kernel.org;
devel@linuxdriverproject.org; vkuznets [off-list ref]
Subject: Re: [PATCH net-next, v2] hv_netvsc: fix vf serial matching with pci slot
info

On Fri, 12 Oct 2018 20:55:15 +0000
Haiyang Zhang [off-list ref] wrote:

Thanks for fixing this.

quoted

+	if (kstrtou32(kobject_name(&pdev->slot->kobj), 10, &serial)) {
+		netdev_notice(vf_netdev, "Invalid vf serial:%s\n",
+			      pdev->slot->kobj.name);
+		return NULL;
+	}

Shouldn't this use kobject_name() in the message as well.

Looking at the pci.h code there is already an API to get name from slot (it uses
kobject_name()). So please use that one.

Sure, I will look for that api. Thanks.