Thread (3 messages) flat view 3 messages, 3 authors, 2018-10-12

Re: [PATCH net-next, v2] hv_netvsc: fix vf serial matching with pci slot info

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2018-10-12 22:21:18
Also in: lkml

On Fri, 12 Oct 2018 20:55:15 +0000
Haiyang Zhang [off-list ref] wrote:

Thanks for fixing this.

  
+	if (kstrtou32(kobject_name(&pdev->slot->kobj), 10, &serial)) {
+		netdev_notice(vf_netdev, "Invalid vf serial:%s\n",
+			      pdev->slot->kobj.name);
+		return NULL;
+	}
Shouldn't this use kobject_name() in the message as well.

Looking at the pci.h code there is already an API to get name from
slot (it uses kobject_name()). So please use that one.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help