Wed, Oct 10, 2018 at 10:27:46PM CEST, Jason@zx2c4.com wrote:

Hey Jiri,

Actually, in the end I went with the suggestion from Andrew and Lukas,
which is to follow Dan's guideline:
https://lkml.org/lkml/2016/8/22/374 . It looks like this:

https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux.git/tree/drivers/net/wireguard/device.c?h=jd/wireguard#n280

I prefer:
                 err = do_something();
                 if (err)
                         goto err_do_something;

But your style is also quite common. Up to you, I guess.

Jason