Re: [PATCH net-next v7 28/28] net: WireGuard secure network tunnel

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2018-10-08 01:06:34
Also in
lkml
Reply to
Eugene Syromiatnikov, 2018-10-06
Hey Eugene,

On Sat, Oct 6, 2018 at 9:43 PM Eugene Syromiatnikov [off-list ref] wrote:
On Sat, Oct 06, 2018 at 04:57:09AM +0200, Jason A. Donenfeld wrote:
quoted
+static int get_allowedips(void *ctx, const u8 *ip, u8 cidr, int family)
+{
+     struct allowedips_ctx *actx = ctx;
+     struct nlattr *allowedip_nest;
+
+     allowedip_nest = nla_nest_start(actx->skb, actx->i++);
Second parameter of nl_nest_start is an attribute type; (ab)using it as
array index leads to special handling of such structures in parsers.
It's better to have some type like WGDEVICE_A_PEER_ITEM and provide an
additional attribute inside it for index (WGPEER_A_INDEX?).
See, for example, commit v4.12-rc1~119^2~131 ("nbd: add a status netlink
command").
quoted
+static int get_peer(struct wireguard_peer *peer, unsigned int index,
+                 struct allowedips_cursor *rt_cursor, struct sk_buff *skb)
+{
+     struct nlattr *allowedips_nest, *peer_nest = nla_nest_start(skb, index);
Same here.
Good point. Actually the index aspect is totally arbitrary and not
useful at all, and so that part can just be entirely excised.

Jason
Thread (47 messages) 47 messages, 7 authors, last reply 2018-10-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help