On Thu, Oct 4, 2018 at 4:36 PM Sowmini Varadhan
[off-list ref] wrote:

Just catching up on this thread, so please excuse any unintentional
misquotes here.

quoted

quoted

quoted

quoted

David: I couldn't find a place in sparc code where any ethernet device
would be registered, so is there a chance that nobody is using it?

SPARC uses a true Open Firmware implementation, so it would register
drivers through the CONFIG_OF infrastructure.

correct

quoted

The calls are not even that old, and clearly added intentionally for sparc,
see commit ba94272d08a7 ("i40e: use eth_platform_get_mac_address()")
which added the first one.

Yes, correct again. Wouldn't PPC also end up doing the same thing?

See also commit c762dff24c06 (for ixgbe) - without this fix sparc systems
will come up with a bogus mac address and then you end up having to
manually fix this in ugly ways.

The of_get_mac_address() portion is not controversial at all I think,
the question was whether we need the fallback to
arch_get_platform_mac_address() in any of the drivers that
call eth_platform_get_mac_address().

      Arnd