Thread (9 messages) 9 messages, 3 authors, 2018-10-30

Re: [PATCH] Fix ss Netid column and Local/Peer_Address

From: Yoann P. <hidden>
Date: 2018-10-30 04:58:02


quoted hunk ↗ jump to hunk
On Mon, 29 Oct 2018 19:20:36 +0100

Stefano Brivio [off-list ref] wrote:
quoted
The actual issue seems to be that in some cases the left delimiter for
the State column is not printed
Much worse, we always print the left delimiter of the last buffered
column, which is usually empty. My bad.

The issue is not so visible in general as we almost always have spaces
to distribute around, but not if you start going below 70/75 columns.
Can you try this?
diff --git a/misc/ss.c b/misc/ss.c
index f99b6874c228..90986b1dc15f 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1260,7 +1260,7 @@ static void render(void)
        while (token) {
                /* Print left delimiter only if we already started a line */
if (line_started++)
-                       printed = printf("%s", current_field->ldelim);
+                       printed = printf("%s", f->ldelim);
                else
                        printed = 0;

I can't reproduce the issue with this modification. :).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help