Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy

Fri, Oct 26, 2018 at 06:02:01PM CEST, dsahern@gmail.com wrote:

On 10/25/18 12:31 AM, Jiri Pirko wrote:

quoted

Wed, Oct 24, 2018 at 05:32:49PM CEST, dsahern@kernel.org wrote:

quoted

From: David Ahern <redacted>

Marco reported an error with hfsc:
root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1
Error: Attribute failed policy validation.

Apparently a few implementations pass TCA_OPTIONS as a binary instead
of nested attribute, so drop TCA_OPTIONS from the policy.

Yeah, this is nice example of a case, where I think it wouldn't hurt to
be a bit more strict. Apparently, the userspace app is buggy. It should
be fixed. Note that I'm aware of the bw compatibility.

Kernel side for hfsc expects TCA_OPTIONS as a binary as well - a struct
tc_hfsc_qopt. Nothing that can be done.

:(