Re: [PATCH net] net: sched: Remove TCA_OPTIONS from policy
From: Marco Berizzi <hidden>
Date: 2018-10-26 20:11:01
quoted hunk ↗ jump to hunk
Il 24 ottobre 2018 alle 17.32 David Ahern [off-list ref] ha scritto: net/sched/sch_api.c | 1 - 1 file changed, 1 deletion(-)diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index 3dc0acf54245..be7cd140b2a3 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c@@ -1309,7 +1309,6 @@ check_loop_fn(struct Qdisc *q, unsigned long cl, struct qdisc_walker *w)const struct nla_policy rtm_tca_policy[TCA_MAX + 1] = { [TCA_KIND] = { .type = NLA_STRING }, * [TCA_OPTIONS] = { .type = NLA_NESTED }, [TCA_RATE] = { .type = NLA_BINARY, .len = sizeof(struct tc_estimator) }, [TCA_STAB] = { .type = NLA_NESTED }, -- 2.11.0
David, Apologies for bothering you again. I applied your patch to 4.19, but after issuing this command: root@Calimero:~# tc qdisc add dev eth0 root handle 1:0 hfsc default 1 root@Calimero:~# ping 10.81.104.1 PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data. ^C
--- 10.81.104.1 ping statistics ---2 packets transmitted, 0 received, 100% packet loss, time 1001ms I'm losing ipv4 connectivity. If I remove the qdisc everything is going to work again: root@Calimero:~# tc qdisc del dev eth0 root root@Calimero:~# ping 10.81.104.1 PING 10.81.104.1 (10.81.104.1) 56(84) bytes of data. 64 bytes from 10.81.104.1: icmp_seq=1 ttl=255 time=0.711 ms ^C
--- 10.81.104.1 ping statistics ---1 packets transmitted, 1 received, 0% packet loss, time 0ms rtt min/avg/max/mdev = 0.711/0.711/0.711/0.000 ms