Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

On Tue, Oct 09, 2018 at 11:13:16AM +0100, David Howells wrote:

YueHaibing [off-list ref] wrote:

quoted

net/rxrpc/output.c: In function 'rxrpc_reject_packets':
net/rxrpc/output.c:527:11: warning:
 variable 'ioc' set but not used [-Wunused-but-set-variable]

It never used since introduction in

I wonder why my compiler doesn't show this warning.

Anyway, NAK: just removing the variable is the wrong fix - you need to look at
the code more closely.  The actual fix is to pass it to kernel_sendmsg()
instead of 2.

But thanks anyway!  Do you want to respin your patch?

quoted

commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")

Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
to go to net, not net-next.

I told him to do that because it wasn't a bugfix...  Probably just Fixes
is the right thing to use though.

regards,
dan carpenter