Thread (9 messages) flat view 9 messages, 4 authors, 2018-10-12

Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

From: David Howells <dhowells@redhat.com>
Date: 2018-10-09 17:29:35
Also in: kernel-janitors

YueHaibing [off-list ref] wrote:
net/rxrpc/output.c: In function 'rxrpc_reject_packets':
net/rxrpc/output.c:527:11: warning:
 variable 'ioc' set but not used [-Wunused-but-set-variable]

It never used since introduction in
I wonder why my compiler doesn't show this warning.

Anyway, NAK: just removing the variable is the wrong fix - you need to look at
the code more closely.  The actual fix is to pass it to kernel_sendmsg()
instead of 2.

But thanks anyway!  Do you want to respin your patch?
commit ece64fec164f ("rxrpc: Emit BUSY packets when supposed to rather than ABORTs")
Btw, this should be a 'Fixes: <commit> ("subject")' line and the patch needs
to go to net, not net-next.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help