Re: [PATCH net-next 20/20] net/bridge: Update br_mdb_dump for strict data checking

On 10/5/18 1:34 AM, David Miller wrote:

From: David Ahern <dsahern@kernel.org>
Date: Thu,  4 Oct 2018 14:33:55 -0700

quoted

@@ -162,6 +162,28 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb,
 	return err;
 }
 
+static int br_mdb_valid_dump_req(const struct nlmsghdr *nlh,
+				 struct netlink_ext_ack *extack)
+{
+	struct br_port_msg *bpm;
+
+	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*bpm))) {
+		NL_SET_ERR_MSG(extack, "Invalid header");
+		return -EINVAL;
+	}
+	if (bpm->ifindex) {

'bpm' is never initialized.

Thanks.

I had not updated the bridge command for strict checking. Doing so and
bridge mdb show generates a trace. Will fix.