Re: [PATCH net-next 20/20] net/bridge: Update br_mdb_dump for strict data checking
From: David Miller <davem@davemloft.net>
Date: 2018-10-05 14:32:13
From: David Ahern <dsahern@kernel.org> Date: Thu, 4 Oct 2018 14:33:55 -0700
quoted hunk ↗ jump to hunk
@@ -162,6 +162,28 @@ static int br_mdb_fill_info(struct sk_buff *skb, struct netlink_callback *cb, return err; } +static int br_mdb_valid_dump_req(const struct nlmsghdr *nlh, + struct netlink_ext_ack *extack) +{ + struct br_port_msg *bpm; + + if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*bpm))) { + NL_SET_ERR_MSG(extack, "Invalid header"); + return -EINVAL; + } + if (bpm->ifindex) {
'bpm' is never initialized.