Re: [PATCH net 3/7] lan78xx: Check for supported Wake-on-LAN modes
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2018-09-25 17:26:52
Also in:
linux-usb, lkml
On 09/25/2018 10:19 AM, Woojung.Huh@microchip.com wrote:
Hi Florian,quoted
@@ -1415,6 +1415,9 @@ static int lan78xx_set_wol(struct net_device *netdev, if (wol->wolopts & WAKE_ARP) pdata->wol |= WAKE_ARP; + if (pdata->wol == 0) + return -EINVAL; +It will make function return when disabling WOL.
Huh, yes, good point.
Is there other place handling this scenario?
How do you mean?
quoted
device_set_wakeup_enable(&dev->udev->dev, (bool)wol->wolopts); phy_ethtool_set_wol(netdev->phydev, wol);Thanks. Woojung
-- Florian