Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates
From: Jakub Kicinski <hidden>
Date: 2018-09-24 22:44:31
On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote:
This patchset adds support for 3 generic and 1 driver-specific devlink parameters. Add documentation for these configuration parameters. Also, this patchset adds support to return proper error code if HWRM_NVM_GET/SET_VARIABLE commands return error code HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED. v1->v2: -Remove hw_tc_offload parameter. -Update all patches with Cc of MAINTAINERS. -Add more description in commit message for device specific parameter. -Add a new Documentation/networking/devlink-params.txt with some generic devlink parameters information. -Add a new Documentation/networking/devlink-params-bnxt_en.txt with devlink parameters information that are supported by bnxt_en driver. Vasundhara Volam (9): devlink: Add generic parameter ignore_ari devlink: Add generic parameter msix_vec_per_pf_max devlink: Add generic parameter msix_vec_per_pf_min
Nobody agreed with me that we need structure the PCIe bits better so I'll let go...
bnxt_en: Use ignore_ari devlink parameter
bnxt_en: return proper error when FW returns
HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED
bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink
params.
bnxt_en: Add a driver specific gre_ver_check devlink parameter.This looks like configuring forwarding rules with devlink, but again, I won't object if I'm the only one who finds this inappropriate. You should CC people who gave you feedback on the previous version.
devlink: Add Documentation/networking/devlink-params.txt devlink: Add Documentation/networking/devlink-params-bnxt.txt