On Wed, Sep 19, 2018 at 04:38:27PM +0100, Edward Cree wrote:

On 19/09/18 15:41, Michal Kubecek wrote:

quoted

I'm sorry I didn't notice this before the patch was accepted but as it's
not in a release yet, maybe it's still not too late.

Could I suggest to make the syntax consistent with other options?

I didn't realise ethtool had any patterns to be consistent with ;)

Way too many, I must say. :-) That is why I wasn't happy about adding
another.

quoted

I mean rather than a comma separated list to use either

  ethtool --set-fec <dev> encoding enc1 enc2 ...

but yes this looks fine to me, as long as we're reasonably confident that
 we won't want to add new parameters (that might require determining
 whether enc2 is an encoding or a parameter name) in the future, because
 while the parsing wouldn't be impossible it might get ugly.

This problem already exists for "-s ... msglvl". In the parser for the
netlink series I introduced an "end of list" marker (tentatively "--")
for this purpose, perhaps that could be a way.

I'll rustle up an RFC patch.

Thank you.

Michal Kubecek