On Wed, Sep 19, 2018 at 05:33:38PM +0200, Andrew Lunn wrote:

quoted

One loosely related question: how sure can we be that we are never going
to need more than 32 bits for FEC encodings? Is it something completely
hypothetical or is it something that could happen in the future?

Hi Michal

Hopefully we have moved to a netlink socket by that time :-)

Actually, that's why I'm asking. :-)

I recently found that EEE still uses a u32 for advertise link modes.
We should fix that in the netlink API.

For EEE it felt obvious that arbitrary length bitmap is the way to go so
I used it (it's still u32 in ethtool_ops but that's easier to change
when needed).

For FEC I wasn't sure if it wouldn't be an overkill.

Michal Kubecek