On Tue, Sep 11, 2018 at 3:25 PM Jiri Pirko [off-list ref] wrote:

Tue, Sep 11, 2018 at 10:44:58AM CEST, vasundhara-v.volam@broadcom.com wrote:

quoted

hw_tc_offload - Enable/Disable TC flower offload in the device.

Signed-off-by: Vasundhara Volam <redacted>
---
include/net/devlink.h | 4 ++++
net/core/devlink.c    | 5 +++++
2 files changed, 9 insertions(+)

diff --git a/include/net/devlink.h b/include/net/devlink.h
index b9b89d6..a0e9ce9 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h

@@ -362,6 +362,7 @@ enum devlink_param_generic_id {
      DEVLINK_PARAM_GENERIC_ID_MAX_MACS,
      DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV,
      DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT,
+      DEVLINK_PARAM_GENERIC_ID_HW_TC_OFFLOAD,

Could you please describe why do you need this here and why the
tc_offload flag in ethtool is not enough. How do you imagine the user
should use them together?

Jiri, tc_offload flag in ethtool will modify feature in driver at
runtime. But I am adding
tc_offload param here to toggle this feature in NVM Config of our
adapter, whose configuration
mode is permanent and will be effective only with a reboot of the server.

User has to turn on tc_offload feature in NVM config of the adapter and then
enabling the tc_offload flag in ethtool will completely enable the
feature in driver.