Re: [PATCH net-next 1/8] devlink: Add generic parameter hw_tc_offload
From: Jiri Pirko <jiri@resnulli.us>
Date: 2018-09-11 14:54:20
Tue, Sep 11, 2018 at 10:44:58AM CEST, vasundhara-v.volam@broadcom.com wrote:
quoted hunk ↗ jump to hunk
hw_tc_offload - Enable/Disable TC flower offload in the device. Signed-off-by: Vasundhara Volam <redacted> --- include/net/devlink.h | 4 ++++ net/core/devlink.c | 5 +++++ 2 files changed, 9 insertions(+)diff --git a/include/net/devlink.h b/include/net/devlink.h index b9b89d6..a0e9ce9 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h@@ -362,6 +362,7 @@ enum devlink_param_generic_id {DEVLINK_PARAM_GENERIC_ID_MAX_MACS, DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV, DEVLINK_PARAM_GENERIC_ID_REGION_SNAPSHOT, + DEVLINK_PARAM_GENERIC_ID_HW_TC_OFFLOAD,
Could you please describe why do you need this here and why the tc_offload flag in ethtool is not enough. How do you imagine the user should use them together?