RE: [PATCH 4/6] net/wan/fsl_ucc_hdlc: default hmask value
From: Qiang Zhao <qiang.zhao@nxp.com>
Date: 2018-08-29 02:54:57
Also in:
linuxppc-dev
From: David Gounaris <redacted> Date: 2018/8/28 19:09
quoted hunk ↗ jump to hunk
Subject: [PATCH 4/6] net/wan/fsl_ucc_hdlc: default hmask value Set default HMASK to 0x0000 to use promiscuous mode in the hdlc controller. Signed-off-by: David Gounaris <redacted> --- drivers/net/wan/fsl_ucc_hdlc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/wan/fsl_ucc_hdlc.h b/drivers/net/wan/fsl_ucc_hdlc.h index c21134c1f180..5bc3d1a6ca6e 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.h +++ b/drivers/net/wan/fsl_ucc_hdlc.h@@ -134,7 +134,7 @@ struct ucc_hdlc_private { #define HDLC_HEAD_MASK 0x0000 #define DEFAULT_HDLC_HEAD 0xff44 -#define DEFAULT_ADDR_MASK 0x00ff +#define DEFAULT_ADDR_MASK 0x0000 #define DEFAULT_HDLC_ADDR 0x00ff #define BMR_GBL 0x20000000 --
It is not proper to set default HMASK to 0x0000, how about to add a new property standing for hmask into device tree, If get this property from dtb, then set it with the value from dtb, otherwise, set it with default HMASK ox00ff? Best Regards Qiang Zhao