Re: [PATCH 2/2] ethernet: lpc_eth: Use NULL to compare with pointer-typed value rather than 0
From: Vladimir Zapolskiy <vz@mleia.com>
Date: 2018-08-17 15:29:06
Also in:
lkml
Hi zhong jiang, On 08/17/2018 04:18 PM, zhong jiang wrote:
quoted hunk ↗ jump to hunk
We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. --- drivers/net/ethernet/nxp/lpc_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 08381ef..04d9e62 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c@@ -1350,7 +1350,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) "IRAM not big enough for net buffers, using SDRAM instead.\n"); } - if (pldat->dma_buff_base_v == 0) { + if (pldat->dma_buff_base_v == NULL) {
That's a valid finding, but please use a common 0 and NULL comparison in form of if (!pldat->dma_buff_base_v) To the change above please feel free to add my Acked-by: Vladimir Zapolskiy <vz@mleia.com>
ret = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) goto err_out_free_irq;