Revision v1 of 2 in this series.
5 messages, 2 authors, 2018-08-18 · open the first message on its own page
From: zhong jiang <hidden>
Date: 2018-08-17 13:30:54
zhong jiang (2):
ethernet: declance: Use NULL to compare with pointer-typed value
rather than 0
ethernet: lpc_eth: Use NULL to compare with pointer-typed value
rather than 0
drivers/net/ethernet/amd/declance.c | 2 +-
drivers/net/ethernet/nxp/lpc_eth.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
1.7.12.4
From: zhong jiang <hidden>
Date: 2018-08-17 13:30:51
We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. --- drivers/net/ethernet/amd/declance.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
index 116997a..6e035df 100644
--- a/drivers/net/ethernet/amd/declance.c
+++ b/drivers/net/ethernet/amd/declance.c@@ -607,7 +607,7 @@ static int lance_rx(struct net_device *dev) len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4; skb = netdev_alloc_skb(dev, len + 2); - if (skb == 0) { + if (skb == NULL) { dev->stats.rx_dropped++; *rds_ptr(rd, mblength, lp->type) = 0; *rds_ptr(rd, rmd1, lp->type) =
--
1.7.12.4
From: zhong jiang <hidden>
Date: 2018-08-17 13:31:00
We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. --- drivers/net/ethernet/nxp/lpc_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
index 08381ef..04d9e62 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c@@ -1350,7 +1350,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) "IRAM not big enough for net buffers, using SDRAM instead.\n"); } - if (pldat->dma_buff_base_v == 0) { + if (pldat->dma_buff_base_v == NULL) { ret = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) goto err_out_free_irq;
--
1.7.12.4
From: Vladimir Zapolskiy <vz@mleia.com>
Date: 2018-08-17 15:29:06
Hi zhong jiang, On 08/17/2018 04:18 PM, zhong jiang wrote:
We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. --- drivers/net/ethernet/nxp/lpc_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 08381ef..04d9e62 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c@@ -1350,7 +1350,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) "IRAM not big enough for net buffers, using SDRAM instead.\n"); } - if (pldat->dma_buff_base_v == 0) { + if (pldat->dma_buff_base_v == NULL) {
That's a valid finding, but please use a common 0 and NULL comparison in form of if (!pldat->dma_buff_base_v) To the change above please feel free to add my Acked-by: Vladimir Zapolskiy <vz@mleia.com>
ret = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) goto err_out_free_irq;
From: zhong jiang <hidden>
Date: 2018-08-18 05:59:42
On 2018/8/17 23:29, Vladimir Zapolskiy wrote:
Hi zhong jiang, On 08/17/2018 04:18 PM, zhong jiang wrote:quoted
We should use NULL to compare with pointer-typed value rather than 0. The issue is detected with the help of Coccinelle. --- drivers/net/ethernet/nxp/lpc_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c index 08381ef..04d9e62 100644 --- a/drivers/net/ethernet/nxp/lpc_eth.c +++ b/drivers/net/ethernet/nxp/lpc_eth.c@@ -1350,7 +1350,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev) "IRAM not big enough for net buffers, using SDRAM instead.\n"); } - if (pldat->dma_buff_base_v == 0) { + if (pldat->dma_buff_base_v == NULL) {That's a valid finding, but please use a common 0 and NULL comparison in form of if (!pldat->dma_buff_base_v) To the change above please feel free to add my Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Thanks, Will do in v2
quoted
ret = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) goto err_out_free_irq;.