Thread (15 messages) 15 messages, 4 authors, 2018-08-05

Re: [PATCH 4.4 106/124] netlink: Do not subscribe to non-existent groups

From: Dmitry Safonov <hidden>
Date: 2018-08-04 23:44:34
Also in: lkml, stable

On Sat, 2018-08-04 at 16:33 -0700, David Miller wrote:
From: Dmitry Safonov <redacted>
Date: Sun, 05 Aug 2018 00:26:38 +0100
quoted
Thanks for the testing, sorry again for the breakage.
Will send the patch shortly (with sizeof(unsigned long long)
instead of
quoted
hard-coded 64). Hopefully, not too late.
'groups' is "long unsigned int" not "unsigned long long"

        long unsigned int groups = nladdr->nl_groups;

And nladdr->nl_groups is specified as "__u32"

So the size of the relevant bits is actually strictly 32-bit.

This makes also the "ULL" in your constant specification incorrect as
well.

So much crazy stuff going on here :-/
Right, I misslooked that..
How does this work on Android then?
I doubt they changed uabi.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help