Thread (15 messages) 15 messages, 4 authors, 2018-08-05

Re: [PATCH 4.4 106/124] netlink: Do not subscribe to non-existent groups

From: David Miller <davem@davemloft.net>
Date: 2018-08-04 23:25:37
Also in: lkml, stable

From: Nathan Chancellor <redacted>
Date: Sat, 4 Aug 2018 16:21:02 -0700
On Sun, Aug 05, 2018 at 12:12:02AM +0100, Dmitry Safonov wrote:
quoted
On Sat, 2018-08-04 at 15:49 -0700, Nathan Chancellor wrote:
quoted
dmesg output attached, please let me know if you need anything else.
Could you try with this diff instead?
It looks like, I'm too bad with shifts and shifted for 64 bytes.

-- 
Thanks,
             Dmitry
quoted
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 7d860a22e5fb..b78bb7dc06fe 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1011,7 +1011,7 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
 
 	if (nlk->ngroups == 0)
 		groups = 0;
-	else
+	else if (nlk->ngroups < 64)
 		groups &= (1ULL << nlk->ngroups) - 1;
 
 	bound = nlk->bound;
This fixed my issue. If needed:

Tested-by: Nathan Chancellor <redacted>
Dmitry please submit this formally for net+stable wit Nathan's
tested-by.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help