Re: [PATCH 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver
From: Arun Parameswaran <hidden>
Date: 2018-07-26 19:16:41
Also in:
linux-arm-kernel, linux-devicetree, lkml
On 18-07-26 12:06 PM, Andrew Lunn wrote:
On Thu, Jul 26, 2018 at 11:36:19AM -0700, Arun Parameswaran wrote:quoted
Modify the register offsets in the Broadcom iProc mdio mux to start from the top of the register address space. Earlier the base address specified was from the middle of the block's register space. The base address will now point to the start of the mdio's address space. The offsets have been fixed to match this.Hi Arun Did you consider a change something like:
That looks good. I will make this change to the patch. Thanks Arun
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c index 0831b7142df7..2d53e609498c 100644 --- a/drivers/net/phy/mdio-mux-bcm-iproc.c +++ b/drivers/net/phy/mdio-mux-bcm-iproc.c@@ -169,6 +169,12 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev) md->dev = &pdev->dev; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + + if (res->start & 0xfff != 0) { + dev_info(&pdev->dev, "Please upgrade your device tree blob.\n"); + res->start &= ~0xfff; + } + md->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(md->base)) { dev_err(&pdev->dev, "failed to ioremap register\n");Andrew