Re: [PATCH 5/7] net: phy: Add support to configure clock in Broadcom iProc mdio mux
From: Andrew Lunn <andrew@lunn.ch>
Date: 2018-07-26 19:13:48
Also in:
linux-arm-kernel, linux-devicetree, lkml
quoted hunk ↗ jump to hunk
@@ -175,6 +198,12 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev) return PTR_ERR(md->base); } + md->core_clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(md->core_clk)) { + dev_info(&pdev->dev, "core_clk not specified\n"); + md->core_clk = NULL; + } +
In the binding, you say the clock is optional. This is a rather strong
message for something which is optional. I think it would be better to
not output anything.
Andrew